On Wed, Jul 18, 2018 at 1:48 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > Also, a minor thing, when doing kernel work you should have: > [core] > abbrev = 12 > > in your .gitconfig as our sha1 numbers are usually longer than the 7 you > sent above. > > Also, here's a handy alias lots of us use: > git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n" > to output the sha1 and commit description. > > It would do this for one of your commits above: > d0a8d9378d16 ("x86/paravirt: Make native_save_fl() extern inline") Neat, thanks for the tip, I was wondering if folks were always counting out 12 characters when copying SHAs... On Wed, Jul 18, 2018 at 2:07 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Wed, Jul 18, 2018 at 10:48:37AM +0200, Greg KH wrote: > > On Tue, Jul 17, 2018 at 04:48:01PM -0700, Nick Desaulniers wrote: > > > Please cherry-pick upstream commits: > > > > > > d03db2b "compiler-gcc.h: Add __attribute__((gnu_inline)) to all inline > > > declarations" > > > > This took a bunch of work to get it to work for 4.9, I didn't mess with > > it for 4.4.y, can you provide a patch series for that tree? Hm, I > > wonder if the same commits I did for 4.9.y would work there, let me try > > that first... > > > > > 0e2e160 "x86/asm: Add _ASM_ARG* constants for argument registers to <asm/asm.h>" > > > > This didn't work for 4.4.y either :( > > > > > d0a8d93 "x86/paravirt: Make native_save_fl() extern inline" > > > > This worked for all. > > Oops, nope, it broke the build on 4.4.y, can you provide a working > backport for there? Was there anything special I should have put in the commit message to show it was changed from upstream? I sent it in reply to this email I'm responding to, but gmail doesn't display it as a child. It can also be found: https://lkml.org/lkml/2018/7/20/1142 but please let me know if there's a better way I should send it. -- Thanks, ~Nick Desaulniers