Re: [BACKPORT PATCH] nvme-pci: Remap CMB SQ entries on every controller reset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 13, 2018 at 02:01:04PM +0200, Greg KH wrote:
> On Thu, Jul 12, 2018 at 03:27:17PM -0600, Scott Bauer wrote:
> > Commit 815c6704bf9f1c59f3a6be380a4032b9c57b12f1 upstream.
> > 
> > The controller memory buffer is remapped into a kernel address on each
> > reset, but the driver was setting the submission queue base address
> > only on the very first queue creation. The remapped address is likely to
> > change after a reset, so accessing the old address will hit a kernel bug.
> > 
> > This patch fixes that by setting the queue's CMB base address each time
> > the queue is created.
> > 
> > Fixes: f63572dff1421 ("nvme: unmap CMB and remove sysfs file in reset path")
> > Reported-by: Christian Black <christian.d.black@xxxxxxxxx>
> > Cc: Jon Derrick <jonathan.derrick@xxxxxxxxx>
> > Signed-off-by: Keith Busch <keith.busch@xxxxxxxxx>
> > Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> > Signed-off-by: Scott Bauer <scott.bauer@xxxxxxxxx>
> > Reviewed-by: Jon Derrick <jonathan.derrick@xxxxxxxxx>
> > ---
> >  drivers/nvme/host/pci.c | 27 ++++++++++++++++-----------
> >  1 file changed, 16 insertions(+), 11 deletions(-)
> 
> "backport" to where?  What kernel tree(s) do you want this applied to?
> 
> I need a hint please...

Sorry about that. 4.9 and 4.14 are the applicable targets.



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux