On Tue, 2018-07-10 at 20:51 +0200, Greg KH wrote: > On Tue, Jul 10, 2018 at 10:32:00AM -0700, Bart Van Assche wrote: > > diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c > > index 325bae29e90d..705f6a992d82 100644 > > --- a/drivers/infiniband/ulp/srpt/ib_srpt.c > > +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c > > @@ -2152,6 +2152,7 @@ static int srpt_cm_req_recv(struct srpt_device *const sdev, > > } > > > > kref_init(&ch->kref); > > + kref_get(&ch->kref); > > kref_init starts the reference count at at 1, so why do you need to > increment it right away? That feels like something is "odd" here, why > do you start with 2 references in the same function? Hi Greg, An ib_srpt RDMA channel object (ch in the above code) must stay around as long as the associated target core session (se_sess) exists and also as long as the target core has not yet called srpt_close_session(). Hence the initialization of ch->kref to 2 just before an RDMA channel is registered with the target core. Hence also the kref_put() calls in srpt_close_session() and srpt_release_channel_work(). Please let me know if you need more information. Thanks, Bart.
