On Sun, Jul 08, 2018 at 02:23:19PM +0300, Ido Schimmel wrote: > Jiri Slaby noticed that the backport of upstream commit 25cc72a33835 > ("mlxsw: spectrum: Forbid linking to devices that have uppers") to > kernel 4.9.y introduced the same check twice in the same function > instead of in two different places. > > Fix this by relocating one of the checks to its intended place, thus > preventing unsupported configurations as described in the original > commit. > > Fixes: 73ee5a73e75f ("mlxsw: spectrum: Forbid linking to devices that have uppers") > Signed-off-by: Ido Schimmel <idosch@xxxxxxxxxxxx> > Reported-by: Jiri Slaby <jslaby@xxxxxxx> > --- > Greg, didn't hear from you, so posting v2. Removed the "commit <sha1> > upstream" line from the changelog which I think is what caused the > confusion. Please let me know if further changes are required. Thanks. Yes, that is what caused my confusion, thanks for resending this. greg k-h