Re: [PATCH] compiler.h, sparse, smatch: Do not define COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 06, 2018 at 10:53:08PM +0000, Bart Van Assche wrote:
> On Sat, 2018-07-07 at 00:46 +0200, Luc Van Oostenryck wrote:
> > 1) it lacks some essential patches to avoid tons of useless noises,
> >    like for example the patch:
> > 	https://patchwork.kernel.org/patch/10334355/
> 
> Hello Luc,
> 
> To suppress the sizeof(void) warnings I sent the following patch to Linus:
> "[PATCH] kernel.h: Avoid that sparse complains about using sizeof(void)"
> (https://lore.kernel.org/lkml/20180705161709.17028-1-bart.vanassche@xxxxxxx/).
> Please advise how to proceed with that patch.

The problems I have with this patch are:
1) it increases the difference between the code as seen by sparse
   and the one seen by GCC. It's fine as temporary band-aid but this
   kind of patches tend to stay forever.
2) it shouldn't really be needed because someone, Joey Pabalinas,
   has already, several months ago, done what is needed on sparse's
   side to suppress this warning as soon as it became a problem.

Of course, the real solution would be to keep the maintenance pace
of sparse's official better in synch with the kernel development
Meanwhile, I understand very well the need of your patch.

-- Luc Van Oostenryck



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux