On Thu, Jul 05, 2018 at 07:52:21PM +0200, Greg KH wrote: > On Thu, Jul 05, 2018 at 08:24:52PM +0300, Ido Schimmel wrote: > > commit 25cc72a33835ed8a6f53180a822cadab855852ac upstream. > > > > Jiri Slaby noticed that the backport of upstream commit 25cc72a33835 > > ("mlxsw: spectrum: Forbid linking to devices that have uppers") to > > kernel 4.9.y introduced the same check twice in the same function > > instead of in two different places. > > > > Fix this by relocating one of the checks to its intended place, thus > > preventing unsupported configurations as described in the original > > commit. > > > > Fixes: 73ee5a73e75f ("mlxsw: spectrum: Forbid linking to devices that have uppers") > > Signed-off-by: Ido Schimmel <idosch@xxxxxxxxxxxx> > > Reported-by: Jiri Slaby <jslaby@xxxxxxx> > > --- > > Greg, I read Documentation/stable_kernel_rules.txt, so I hope the patch > > is fine. Please let me know if v2 is required. Thanks > > This commit is already in 4.9.51, why do you need/want it applied again? It wasn't clear to me if I need to specify "commit <sha1> upstream" also for fixes of backports. You want me to post v2 without this line? Thanks