On Wed, Jul 04, 2018 at 01:44:48PM +0200, Alexandru Moise wrote: > On Wed, Jul 04, 2018 at 01:31:54PM +0200, Greg KH wrote: > > On Wed, Jul 04, 2018 at 04:29:09PM +0530, Harsh 'Shandilya wrote: > > > On 4 July 2018 3:25:06 PM IST, Alexandru Moise <00moses.alexander00@xxxxxxxxx> wrote: > > > >On Wed, Jul 04, 2018 at 11:16:44AM +0200, Greg KH wrote: > > > >> On Tue, Jul 03, 2018 at 11:44:53PM +0200, Alexandru Moise wrote: > > > >> > commit cd4a4ae4683dc2e09380118e205e057896dcda2b upstream. > > > >> > > > >> Who wrote this patch? Please keep the correct ownership of > > > >patches... > > > >> > > > >This is Jenses work, I have absolutely nothing to do with it. I just > > > >want > > > >to make sure it reaches 4.17, I tried my best to follow these > > > >guidelines: > > > > > > > >https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > > > > > > > >I assumed that the first Signed-off is implicitly the author of the > > > >patch. > > > >Is there something I am missing? Am I misinterpeting the stable kernel > > > >rules? > > > > > > If you use git format-patch and git send-email for your patches, > > > they'll come out looking like > > > https://www.spinics.net/lists/stable/msg236090.html, which appears to > > > be the proper format since Greg applied those patches without pointing > > > out any flaws in the format. > > > > That is correct, you need the first line that says "From:" to show that > > the patch comes from someone other than you. Please fix that up and > > resend. > Understood, thank you for your patience. I was used to just sending patches, > with mutt. mutt works great too, just don't change the author "from:" line :)