Re: [PATCH] IB/srpt: Support HCAs with more than two ports

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/29/18 09:21, Jason Gunthorpe wrote:
On Tue, Jun 26, 2018 at 03:24:48PM -0700, Bart Van Assche wrote:
Since there are adapters that have four ports, increase the size of
the srpt_device.port[] array. This patch avoids that the following
warning is hit with quad port Chelsio adapters:

     WARN_ON(sdev->device->phys_port_cnt > ARRAY_SIZE(sdev->port));

Reported-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx>
Cc: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx>
---
  drivers/infiniband/ulp/srpt/ib_srpt.c | 6 +++---
  drivers/infiniband/ulp/srpt/ib_srpt.h | 2 +-
  2 files changed, 4 insertions(+), 4 deletions(-)

Can we write it this way instead? More typesafe.

Hello Jason,

The patch you posted looks fine to me. Do you want me to add your Signed-off-by after I have retested this patch when I repost it?

Thanks,

Bart.




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux