Hi balbi, It means that the mainline keep checking stall status first before handle clear-halt request? as usb spec, it's actually okay to send Clear Halt at any time. But dwc3 core hanging with macOS adb application, so I think there is other rootcase why dwc3 hanging , and current patch just for avoid this case. Right? If someday WindonwPC/LINUX PC meet this case again liked my case, would you plan to revert it ? or other plan ? Liang Shengjun HISILICON TECHNOLOGIES CO., LTD. New R&D Center, Wuhe Road, Bantian, Longgang District, Shenzhen 518129 P.R. China -----邮件原件----- 发件人: Felipe Balbi [mailto:felipe.balbi@xxxxxxxxxxxxxxx] 发送时间: 2018年6月25日 15:48 收件人: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> 抄送: liangshengjun <liangshengjun@xxxxxxxxxxxxx>; stable@xxxxxxxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx 主题: Re: make a confirm for [usb: dwc3: gadget: skip Set/Clear Halt when invalid] Hi, Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> writes: >> that patch is not 100% correct. You can revert it in your tree. I >> added that because of a problem I found when running adb against macOS. >> >> It's actually okay to send Clear Halt at any time, but for some >> reason >> dwc3 was hanging when running adb against macOS. > > Note: According to the USB spec it's okay to send Clear-Halt at any > time. But there are plenty of devices that get upset if they receive > this message when the endpoint isn't actually halted. right. The weird thing here is that dwc3 has never suffered from this until we ran ADB against macOS. That was the only way to get any problems. Without clear halt, though, we have no means for syncing data toggle. -- balbi
