On Tue, Jun 26, 2018 at 08:39:36AM -0700, Bart Van Assche wrote:
> Every function that returns COMPST_ERROR must set wqe->status to
> another value than IB_WC_SUCCESS before returning COMPST_ERROR. Fix
> the only code path for which this is not yet the case.
It is unclear to me why other places left out from this fix (e.x. lines
248, 288 etc).
>
> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx>
> Cc: Zhu Yanjun <yanjun.zhu@xxxxxxxxxx>
> Cc: Jianchao Wang <jianchao.w.wang@xxxxxxxxxx>
> Cc: Yuval Shaia <yuval.shaia@xxxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx>
> ---
>
> Changes compared to v1: left out a pr_err() statement as requested by Jason.
>
> drivers/infiniband/sw/rxe/rxe_comp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_comp.c b/drivers/infiniband/sw/rxe/rxe_comp.c
> index 98d470d1f3fc..83311dd07019 100644
> --- a/drivers/infiniband/sw/rxe/rxe_comp.c
> +++ b/drivers/infiniband/sw/rxe/rxe_comp.c
> @@ -276,6 +276,7 @@ static inline enum comp_state check_ack(struct rxe_qp *qp,
> case IB_OPCODE_RC_RDMA_READ_RESPONSE_MIDDLE:
> if (wqe->wr.opcode != IB_WR_RDMA_READ &&
> wqe->wr.opcode != IB_WR_RDMA_READ_WITH_INV) {
> + wqe->status = IB_WC_FATAL_ERR;
> return COMPST_ERROR;
> }
> reset_retry_counters(qp);
> --
> 2.17.1
>
