On Thu, Jun 21, 2018 at 01:29:44PM -0400, Boris Ostrovsky wrote: > Commit 910f8befdf5b ("xen/pirq: fix error path cleanup when binding > MSIs") fixed a couple of errors in error cleanup path of > xen_bind_pirq_msi_to_irq(). This cleanup allowed a call to > __unbind_from_irq() with an unbound irq, which would result in > triggering the BUG_ON there. > > Since there is really no reason for the BUG_ON (xen_free_irq() can > operate on unbound irqs) we can remove it. > > Reported-by: Ben Hutchings <ben.hutchings@xxxxxxxxxxxxxxx> > Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx> Thanks, I had this on my queue of TODOs.