On Mon, 2018-05-28 at 12:03 +0200, Greg Kroah-Hartman wrote: > 4.4-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Brad Love <brad@xxxxxxxxxxxxxxxx> > > [ Upstream commit 5ceade1d97fc6687e050c44c257382c192f56276 ] > > Currently clk_freq is ignored entirely, because the cx235840 driver > configures the xtal at the chip defaults. This is an issue if a > board is produced with a non-default frequency crystal. If clk_freq > is not zero the cx25840 will attempt to use the setting provided, > or fall back to defaults otherwise. This depends on (at least): commit 3ee9bc12342cf546313d300808ff47d7dbb8e7db Author: Brad Love <brad@xxxxxxxxxxxxxxxx> Date: Tue Mar 6 14:15:34 2018 -0500 media: cx25840: Use subdev host data for PLL override Ben. > Signed-off-by: Brad Love <brad@xxxxxxxxxxxxxxxx> > Signed-off-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx> > Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxxxx> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > --- > drivers/media/pci/cx23885/cx23885-cards.c | 4 ++++ > 1 file changed, 4 insertions(+) > > --- a/drivers/media/pci/cx23885/cx23885-cards.c > +++ b/drivers/media/pci/cx23885/cx23885-cards.c > @@ -2124,6 +2124,10 @@ void cx23885_card_setup(struct cx23885_d > &dev->i2c_bus[2].i2c_adap, > "cx25840", 0x88 >> 1, NULL); > if (dev->sd_cx25840) { > + /* set host data for clk_freq configuration */ > + v4l2_set_subdev_hostdata(dev->sd_cx25840, > + &dev->clk_freq); > + > dev->sd_cx25840->grp_id = CX23885_HW_AV_CORE; > v4l2_subdev_call(dev->sd_cx25840, core, load_fw); > } -- Ben Hutchings, Software Developer Codethink Ltd https://www.codethink.co.uk/ Dale House, 35 Dale Street Manchester, M1 2HF, United Kingdom