Subject: + drivers-memstick-core-ms_blockc-fix-unreachable-state-in-h_msb_read_page.patch added to -mm tree To: rogerable@xxxxxxxxxxx,maximlevitsky@xxxxxxxxx,stable@xxxxxxxxxxxxxxx From: akpm@xxxxxxxxxxxxxxxxxxxx Date: Tue, 05 Nov 2013 13:08:39 -0800 The patch titled Subject: drivers/memstick/core/ms_block.c: fix unreachable state in h_msb_read_page() has been added to the -mm tree. Its filename is drivers-memstick-core-ms_blockc-fix-unreachable-state-in-h_msb_read_page.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/drivers-memstick-core-ms_blockc-fix-unreachable-state-in-h_msb_read_page.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/drivers-memstick-core-ms_blockc-fix-unreachable-state-in-h_msb_read_page.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Roger Tseng <rogerable@xxxxxxxxxxx> Subject: drivers/memstick/core/ms_block.c: fix unreachable state in h_msb_read_page() In h_msb_read_page() in ms_block.c, flow never reaches case MSB_RP_RECIVE_STATUS_REG. This causes error when MEMSTICK_INT_ERR is encountered and status error bits are going to be examined, but the status will never be copied back. Fix it by transitioning to MSB_RP_RECIVE_STATUS_REG right after MSB_RP_SEND_READ_STATUS_REG. Signed-off-by: Roger Tseng <rogerable@xxxxxxxxxxx> Acked-by: Maxim Levitsky <maximlevitsky@xxxxxxxxx> Cc: <stable@xxxxxxxxxxxxxxx> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> --- drivers/memstick/core/ms_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/memstick/core/ms_block.c~drivers-memstick-core-ms_blockc-fix-unreachable-state-in-h_msb_read_page drivers/memstick/core/ms_block.c --- a/drivers/memstick/core/ms_block.c~drivers-memstick-core-ms_blockc-fix-unreachable-state-in-h_msb_read_page +++ a/drivers/memstick/core/ms_block.c @@ -401,7 +401,7 @@ again: sizeof(struct ms_status_register))) return 0; - msb->state = MSB_RP_RECEIVE_OOB_READ; + msb->state = MSB_RP_RECIVE_STATUS_REG; return 0; case MSB_RP_RECIVE_STATUS_REG: _ Patches currently in -mm which might be from rogerable@xxxxxxxxxxx are drivers-memstick-core-ms_blockc-fix-unreachable-state-in-h_msb_read_page.patch -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html