On Wed, May 30, 2018 at 9:24 PM, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, May 30, 2018 at 11:46:45AM -0700, Guenter Roeck wrote:
>> On Wed, May 30, 2018 at 03:55:04PM +0200, Arnd Bergmann wrote:
>> > On Wed, May 30, 2018 at 3:31 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>> > > On 05/30/2018 02:27 AM, Arnd Bergmann wrote:
>> > > Presumably this is due to
>> > >
>> > > arch/sparc/kernel/Makefile:ccflags-y := -Werror
>> >
>> > Right, I have disabled that warning locally, so I didn't get
>> > it despite the -Werror.
>> >
>>
>> Would it make sense to add
>> KBUILD_CFLAGS += $(call cc-option,-Wno-attribute-alias)
>> to the sparc Makefile ? It seems to fix the problem for me, and it would
>> be easier to backport than a more comprehensive fix.
>
> Why is that not an option enabled for all arches right now for gcc-8?
I would still want this warning enabled by default in future kernels,
just disabled
for the system call definitions (until we decide to rework the way
they are defined).
What I'd suggest we do is a series of patches:
1. disable both -Wno-attribute-alias and -Wstringop-truncation by
default, but leave them
enabled in 'make W=1'. Mark this one for stable backports
2. add a macro to let users disable warnings locally within a file,
based on _Pragma("GCC
diagnostic ...")
3. change the system call macros to disable -Wno-attribute-alias inside of the
SYSCALL_DEFINEx() macros
4. turn on -Wno-attribute-alias again by default.
Arnd
