Hello,
On Tue, 29 May 2018 23:31:41 +0000
IKEGAMI Tokunori <ikegami@xxxxxxxxxxxxxxxxxxxx> wrote:
> Hi Boris-san,
>
> Thanks for your reviewing and advices.
>
> > Is this really a bug fix? Doesn't look like a bug fix to me.
>
> No as you mentioned it is not a bug fix but just a refactoring to reduce xip_enable() line.
Then you should drop the Cc: stable tag.
>
> > Also, every time you add Cc stable you should try to find the commit
> > that introduced the bug. Sometime it's not possible because the bug
> > existed before git was in use, but most of the time you'll find the
> > offending commit using git blame.
> >
> > A fixes tag should be formatted like that:
> >
> > Fixes: <commit-id> ("commit subject")
>
> Okay I will do that in future.
>
> This is just FYI.
> I have just confirmed that the xip_enable() line itself was implemented by the commit 02b15e343aeef.
> For this patch it is not a bug fix so I will not add the Fixes line into the commit message.
Right.
> But if needed it please let me know that.
I checked the first patch and it seems it's one of these situation
where the code predates git, so no need to specify a Fixes tag.
Thanks,
Boris
