On Thu, 2013-10-31 at 07:06 -0400, Jeff Layton wrote: +AD4- On Thu, 31 Oct 2013 15:04:08 +-0800 +AD4- Rui Xiang +ADw-rui.xiang+AEA-huawei.com+AD4- wrote: +AD4- +AD4- +AD4- Hi Benny, Jeff or Trond, +AD4- +AD4- +AD4- +AD4- f6488c9ba51d65410e2dbc4345413c0d9120971e +AD4- +AD4- nfs: don't allow nfs+AF8-find+AF8-actor to match inodes of the wrong type +AD4- +AD4- +AD4- +AD4- This looks applicable to stable-3.4, that fix an oops introduced by putting +AD4- +AD4- a null pointer and found in RHEL6. It was built successful for me. +AD4- +AD4- What do you think? +AD4- +AD4- +AD4- +AD4- Thanks+ACE- +AD4- +AD4- Rui Xiang +AD4- +AD4- +AD4- +AD4- I've no objection to adding it to stable. It should be reasonably safe +AD4- and will be included in RHEL6.5. +AD4- +AD4- IIRC, the reason we didn't do that before was that it required a server +AD4- that was misbehaving in a particular way and we didn't know of any in +AD4- the field. Exactly. So in this situation you might as well fix the broken server, which is sending out non-unique filehandles in flagrant violation of the NFS specs. Patching the client is just papering over the real problem. That said, the patch itself should be more or less harmless to the client, and it does increase robustness against said broken servers. -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust+AEA-netapp.com www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html