Re: [PATCH 4.4 49/72] media: usbtv: prevent double free in error case

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 4.4 49/72] media: usbtv: prevent double free in error case
From: Oliver Neukum <oneukum@xxxxxxxx>
Date: Tue, 15 May 2018 11:53:27 +0200
Cc: Tuba Yavuz <tuba@xxxxxxxxxxx>, GregKroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, stable@xxxxxxxxxxxxxxx
In-reply-to: <1526319669.9159.20.camel@codethink.co.uk>

Am Montag, den 14.05.2018, 18:41 +0100 schrieb Ben Hutchings:
> 
> Shouldn't this bump the V4L2 device's reference count, i.e.:
> 
> 	v4l2_device_get(&usbtv->v4l2_dev);
> 

<censored>

You are right. Mixing refcounting sucks. I am preparing a patch.

	Regards
		Oliver

References:
- [PATCH 4.4 00/72] 4.4.127-stable review
  - From: Greg Kroah-Hartman
- [PATCH 4.4 49/72] media: usbtv: prevent double free in error case
  - From: Greg Kroah-Hartman
- Re: [PATCH 4.4 49/72] media: usbtv: prevent double free in error case
  - From: Ben Hutchings

Prev by Date: patch "staging: android: ion: Switch to pr_warn_once in ion_buffer_destroy" added to staging-next
Next by Date: [PATCH v3 1/4] ovl: use insert_inode_locked4() to hash a newly created inode
Previous by thread: Re: [PATCH 4.4 49/72] media: usbtv: prevent double free in error case
Next by thread: [PATCH 4.4 70/72] spi: davinci: fix up dma_mapping_error() incorrect patch
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel] [Kernel Development Newbies] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite Hiking] [Linux Kernel] [Linux SCSI]

Powered by Linux