On Thu, 2018-05-10 at 17:54 -0700, Dhinakaran Pandiyan wrote:
> Entry corresponding to 220 us setup time was missing. I am not aware
> of
> any specific bug this fixes, but this could potentially result in
> enabling
> PSR on a panel with a higher setup time requirement than supported by
> the
> hardware.
It should be 'a lower setup time'.
Sink sets 2h requesting 220us but source will only wait 165us.
Other than that looks good:
Reviewed-by: José Roberto de Souza <jose.souza@xxxxxxxxx>
>
> I verified the value is present in eDP spec versions 1.3, 1.4 and
> 1.4a.
>
> Fixes: 6608804b3d7f ("drm/dp: Add drm_dp_psr_setup_time()")
> Cc: stable@xxxxxxxxxxxxxxx
> Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> Cc: Jose Roberto de Souza <jose.souza@xxxxxxxxx>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@xxxxxxxxx>
> ---
> drivers/gpu/drm/drm_dp_helper.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c
> b/drivers/gpu/drm/drm_dp_helper.c
> index 36c7609a4bd5..a7ba602a43a8 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -1159,6 +1159,7 @@ int drm_dp_psr_setup_time(const u8
> psr_cap[EDP_PSR_RECEIVER_CAP_SIZE])
> static const u16 psr_setup_time_us[] = {
> PSR_SETUP_TIME(330),
> PSR_SETUP_TIME(275),
> + PSR_SETUP_TIME(220),
> PSR_SETUP_TIME(165),
> PSR_SETUP_TIME(110),
> PSR_SETUP_TIME(55),
