Hi Chris,
On Fri, 4 May 2018 00:06:48 +0000, Chris Packham
<Chris.Packham@xxxxxxxxxxxxxxxxxxx> wrote:
> Hi Miquel,
>
> On 03/05/18 22:00, Miquel Raynal wrote:
> > One layout supported by the Marvell NAND controller supports NAND pages
> > of 2048 bytes, all handled in one single chunk when using BCH with a
> > strength of 4-bit per 512 bytes. In this case, instead of the generic
> > XTYPE_WRITE_DISPATCH/XTYPE_LAST_NAKED_RW couple, the controller expects
> > to receive XTYPE_MONOLITHIC_RW.
> >
> > This fixes problems at boot like:
> >
> > [ 1.315475] Scanning device for bad blocks
> > [ 3.203108] marvell-nfc f10d0000.flash: Timeout waiting for RB signal
> > [ 3.209564] nand_bbt: error while writing BBT block -110
> > [ 4.243106] marvell-nfc f10d0000.flash: Timeout waiting for RB signal
> > [ 5.283106] marvell-nfc f10d0000.flash: Timeout waiting for RB signal
> > [ 5.289562] nand_bbt: error -110 while marking block 2047 bad
> > [ 6.323106] marvell-nfc f10d0000.flash: Timeout waiting for RB signal
> > [ 6.329559] nand_bbt: error while writing BBT block -110
> > [ 7.363106] marvell-nfc f10d0000.flash: Timeout waiting for RB signal
> > [ 8.403105] marvell-nfc f10d0000.flash: Timeout waiting for RB signal
> > [ 8.409559] nand_bbt: error -110 while marking block 2046 bad
> > ...
> >
> > Fixes: 02f26ecf8c772 ("mtd: nand: add reworked Marvell NAND controller driver")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
>
> For the following combinations
>
> SoC NAND Size EB Page OOB
> --- ---- ---- -- ---- ---
> Armada-385 Micron MT29F8G08ABACAWP 1024 MiB 256 KiB 4096 224
> Armada-385 Micron MT29F2G08ABAEAWP 256 MiB 128 KiB 2048 64
> Armada-385 Macronix MX30LF2G18AC 256 MiB 128 KiB 2048 64
> Armada-98DX4251 AMD/Spansion S34ML08G2 1024 MiB 128 KiB 2048 128
> Armada-98DX4251 Macronix MX60LF8G18AC 1024 MiB 128 KiB 2048 64
> Armada-98DX4251 Micron MT29F8G08ABABAWP 1024 MiB 512 KiB 4096 224
>
> Tested-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>
Thank you very much for testing all this!
>
> I do have one platform that passes the initial detection but starts to
> report ubifs errors when mounted.
>
> Armada-98DX4251 Micron MT29F8G08ABACAWP 1024 MiB 256 KiB 4096 224
>
> This is probably unrelated to this particular fix. It may be as simple
> as something not catering for the Armada-98DX4251 SoC or a genuine
> difference between Armada-98DX4251 and Armada-385. 4.16.4 with
> pxa3xx_nand works with this combination.
Can you please share more details: the device tree (at least the NAND
node), the strength requested, the boot log, the errors?
Are you sure Linux ECC configuration is aligned with the bootloader's?
Thanks,
Miquèl
--
Miquel Raynal, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
