Re: Request for stable 4.14.x inclusion: net: don't call update_pmtu unconditionally

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2018-04-22 23:50, Thomas Deutschmann wrote:
> Hi,
> 
> please add
> 
>> From f15ca723c1ebe6c1a06bc95fda6b62cd87b44559 Mon Sep 17 00:00:00 2001
>> From: Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx>
>> Date: Thu, 25 Jan 2018 19:03:03 +0100
>> Subject: net: don't call update_pmtu unconditionally
>>
>> Some dst_ops (e.g. md_dst_ops)) doesn't set this handler. It may result to:
>> "BUG: unable to handle kernel NULL pointer dereference at           (null)"
>>
>> Let's add a helper to check if update_pmtu is available before calling it.
>>
>> Fixes: 52a589d51f10 ("geneve: update skb dst pmtu on tx path")
>> Fixes: a93bf0ff4490 ("vxlan: update skb dst pmtu on tx path")
>> CC: Roman Kapl <code@xxxxxxxx>
>> CC: Xin Long <lucien.xin@xxxxxxxxx>
>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx>
>> Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> 
> to 4.14.x.
> 
> This fixes NULL derefs caused by a93bf0ff4490 ("vxlan: update
> skb dst pmtu on tx path"), which was backported to 4.14.24.

*ping* - Not yet applied and not yet queued. Is there a problem with the
patch which prevents a cherry-pick for 4.14.x?


-- 
Regards,
Thomas Deutschmann / Gentoo Linux Developer
C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]