On Fri, Apr 27, 2018 at 09:05:21AM +0200, Greg KH wrote:
> On Thu, Apr 26, 2018 at 09:50:25PM -0700, Nathan Chancellor wrote:
> > On Fri, Apr 27, 2018 at 02:01:20AM +0000, Sasha Levin wrote:
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA512
> > >
> > > Hi Greg,
> > >
> > > Pleae pull commits for Linux 4.4 .
> > >
> > > I've sent a review request for all commits over a week ago and all
> > > comments were addressed.
> > >
> > >
> > > Thanks,
> > > Sasha
> > >
> >
> > For what it's worth, commit 87a00850c711 ("pinctrl: msm: Use dynamic
> > GPIO numbering") completely breaks touchscreen input on my Pixel 2 XL.
>
> That's not good. Have you reported this to the gpio developers and
> authors of that patch?
>
I have not although I've gone ahead and CC'd them on this email.
> > I'm happy to carry the revert in my tree given it is probably a correct
> > change in mainline but I figured I would let you guys know so you can
> > make that decision.
>
> Ah, do you think this is a userspace issue with your device and not a
> kernel problem? That implies that this patch isn't ok and should be
> reverted upstream.
>
I don't think this is a userspace regression. My guess is certain
out of tree drivers expect a static base value, based on the wording
of the commit message. Unfortunately, his is all a little bit over
my head at the moment. I will try to study up on it tomorrow. I just
wanted to report the regression as soon as I uncovered it (I'd be
lying if I said I liked reporting bugs heh).
Thanks!
Nathan