On Thu, Apr 26, 2018 at 11:37 AM, Greg KH <greg@xxxxxxxxx> wrote:
> On Thu, Apr 26, 2018 at 10:46:50AM -0700, Dmitry Shmidt wrote:
>> Please add this patch to stable 4.14
>>
>> commit f54450ad1942287cc76b38021c0441fc4901d2de
>> Author: Kees Cook <keescook@xxxxxxxxxxxx>
>> Date: Tue Feb 27 13:11:21 2018 -0800
>>
>> console: Drop added "static" for newport_con
>>
>> Commit 4fe505119778 ("console: Expand dummy functions for CFI") accidentally
>> added "static" to newport_con instance of struct consw, while trying to
>> normalize the declarations. This, however, needed to stay non-static as it
>> has an extern.
>>
>> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
>> Fixes: 4fe505119778 ("console: Expand dummy functions for CFI")
>> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>
>
> Why does 4.14.y need it?
https://kernelci.org/build/android/branch/android-4.14/kernel/ASB-2018-04-05_4.14-637-gbb60f28e486c/
Errors Summary
2drivers/video/console/newport_con.c:683:27: error: static declaration
of 'newport_con' follows non-static declaration
> It really fixes commit c396a5bf457f ("console: Expand dummy functions
> for CFI") which only showed up in 4.17-rc1.
>
> Why would 4.14.y need it?
>
> confused,
>
> greg k-h