Re: [PATCH] random: fix possible sleeping allocation from irq context

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Theodore Ts\'o wrote:
> We can do a sleeping allocation from an irq context when CONFIG_NUMA
> is enabled.  Fix this by initializing the NUMA crng instances in a
> workqueue.

Offloading to workqueue context itself would be OK,
but this patch makes linux.git unbootable because

	if (crng == &primary_crng && crng_init < 2) {
		invalidate_batched_entropy();
		numa_crng_init(); // <= Deferred to workqueue context.
		crng_init = 2; // <= Not waiting for workqueue context, and oops before console becomes ready. ;-)
		process_random_ready_list();
		wake_up_interruptible(&crng_init_wait);
		pr_notice(\"random: crng init done\\n\");
	}

Please don\'t pretend rng_ready() before workqueue context is processed.



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]