On Thu, 2013-10-24 at 16:14 +0800, Huang Shijie wrote:
> int common_nfc_set_geometry(struct gpmi_nand_data *this)
> {
> - return set_geometry_by_ecc_info(this) ? 0 : legacy_set_geometry(this);
> + return legacy_set_geometry(this) ? set_geometry_by_ecc_info(this) : 0;
So... what if someone has already shipped the new chips that require
stronger ECC, without realising that legacy_set_geometry() is
insufficient? (And is legacy_set_geometry *actually* doing precisely the
same as 3.10/3.11?)
Do we forcibly upgrade them to the new method, and compatibility be
damned?
I'm inclined to suggest that for the 3.12 release we just need to use
legacy_set_geometry(), and allow it to work with a *warning*, and then
for 3.13 we can finish thrashing out the precise behaviour we need —
which may indeed end up being that you do the new method *only* if the
corresponding property exists in the device tree.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@xxxxxxxxx Intel Corporation
Attachment:
smime.p7s
Description: S/MIME cryptographic signature