On Wed, Oct 23, 2013 at 07:58:19PM -0700, Brian Norris wrote: > This patch fixes two memory errors: > > 1. During a probe failure (in mtd_device_parse_register?) the command > buffer would not be freed. > > 2. The command buffer's size is determined based on the 'fast_read' > boolean, but the assignment of fast_read is made after this > allocation. Thus, the buffer may be allocated "too small". > > To fix the first, just switch to the devres version of kzalloc. > > To fix the second, increase MAX_CMD_SIZE unconditionally. It's not worth > saving a byte to fiddle around with the conditions here. > > This problem was reported by Yuhang Wang a while back. > > Signed-off-by: Brian Norris <computersforpeace@xxxxxxxxx> > Reported-by: Yuhang Wang <wangyuhang2014@xxxxxxxxx> > Cc: <stable@xxxxxxxxxxxxxxx> I pushed patches 1, 2, and 3 to l2-mtd.git (for Sourav's sake). I'll wait a little while on the others. Comments are still welcome on the whole series, though. Brian -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html