<pkshih@xxxxxxxxxxx> writes:
> From: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
>
> The module parameter ant_sel is used to control antenna number and path.
> There is an existing enum ANT_{X2,X1} defined the antenna number, so
> add a new enum ANT_{MAIN,AUX} to make it readable. After this work,
> incorrect given values depend on ant_sel were exposed, so refill values
> according following definition:
> ant_sel ant_num ant_path print_label
> 1 ANT_X1 ANT_AUX #2
> 2 ANT_X2 ANT_MAIN #1
> Then, the workaround in halbtcoutsrc.c was removed.
>
> The experimental results with single antenna connected to specific path
> are in following:
> ant_sel ANT_MAIN(#1) ANT_AUX(#2)
> 0 -8 -62
> 1 -62 -10
> 2 -6 -60
>
> Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx>
> Cc: Stable <stable@xxxxxxxxxxxxxxx> # 4.7+
> Reviewed-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
> ---
> Hi Kalle,
>
> This patch would send to 4.17.
For -rc releases I require a quite clear bug report but I do not
understand what you are fixing here, even after reading the commit log
twice. Could you try to improve it? Especially focus on describing the
bug in simple terms and how this patch changes the functionality from
user's point of view.
--
Kalle Valo