On Mon, 16 Apr 2018 13:17:24 -0700 Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > On Mon, Apr 16, 2018 at 1:02 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > > > But this is going way off topic to what we were discussing. The > > discussion is about what gets backported. Is automating the process > > going to make stable better? Or is it likely to add more regressions. > > > > Sasha's response has been that his automated process has the same rate > > of regressions as what gets tagged by authors. My argument is that > > perhaps authors should tag less to stable. > > The ones who should matter most for that discussion is the distros, > since they are the actual users of stable (as well as the people doing > the work, of course - ie Sasha and Greg and the rest of the stable > gang). That was actually my final conclusion before we started out discussion ;-) http://lkml.kernel.org/r/20180416143510.79ba5c63@xxxxxxxxxxxxxxxxxx > > And I suspect that they actually do want all the noise, and all the > stuff that isn't "critical". That's often the _easy_ choice. It's the > stuff that I suspect the stable maintainers go "this I don't even have > to think about", because it's a new driver ID or something. Although Red Hat doesn't base off of the stable kernel. At least it didn't when I was there. They may look at the stable kernel, but they make their own decisions. If we want the distros to use stable as the base, it should be the least common factor among them. Otherwise, if stable includes commits that a distro would rather not backport, then they wont use stable. > > Because the bulk of stable tends to be driver updates, afaik. Which > distros very much tend to want. > > Will developers think that their patches matter so much that they > should go to stable? Yes they will. Will they overtag as a result? > Probably. But the reverse likely also happens, where people simply > don't think about stable at all, and just want to fix a bug. > > In many ways "Fixes" is likely a better thing to check for in stable > backports, but that doesn't always exist either. > > And just judging by the amount of stable email I get - and by how > excited _I_ would be about stable work, I think "automated process" is > simply not an option. It's a _requirement_. You'd go completely crazy > if you didn't automate 99% of all the stable work. > > So can you trust the "Cc: stable" as being perfect? Hell no. But > what's your alternative? Manually selecting things for stable? Asking > the developers separately? > > Because "criticality" definitely isn't what determines it. If it was, > we'd never add driver ID's etc to stable - they're clearly not > "critical". True. But I believe the driver ID's was given the "exception". > > Yet it feels like that's sometimes those driver things are the _bulk_ > of it, and it is usually fairly safe (not quite as obviously safe as > you'd think, because a driver ID addition has occasionally meant not > just "now it's supported", but instead "now the generic driver doesn't > trigger for it any more", so it can actually break things). > > So I think - and _hope_ - that 99% of stable should be the > non-critical stuff that people don't even need to think about. > > The critical stuff is hopefully a tiny tiny percentage. Well, I'm not sure that's really the case. $ git log --oneline v4.14.33..v4.14.34 | head -20 ffebeb0d7c37 Linux 4.14.34 fdae5b620566 net/mlx4_core: Fix memory leak while delete slave's resources 9fdeb33e1913 vhost_net: add missing lock nesting notation 8c316b625705 team: move dev_mc_sync after master_upper_dev_link in team_port_add 233ba28e1862 route: check sysctl_fib_multipath_use_neigh earlier than hash 2f8aa659d4c0 vhost: validate log when IOTLB is enabled 72b880f43990 net/mlx5e: Fix traffic being dropped on VF representor 9408bceb0649 net/mlx4_en: Fix mixed PFC and Global pause user control requests 477c73abf26a strparser: Fix sign of err codes 1c71bfe84deb net/sched: fix NULL dereference on the error path of tcf_skbmod_init() a19024a3f343 net/sched: fix NULL dereference in the error path of tunnel_key_init() e096c8bf4fb8 net/mlx5e: Sync netdev vxlan ports at open baab1f0c4885 net/mlx5e: Don't override vport admin link state in switchdev mode 1ec7966ab7db ipv6: sr: fix seg6 encap performances with TSO enabled e52a45bb392f nfp: use full 40 bits of the NSP buffer address ddf79878f1e0 net/mlx5e: Fix memory usage issues in offloading TC flows 9282181c1cc5 net/mlx5e: Avoid using the ipv6 stub in the TC offload neigh update path b9c6ddda3805 vti6: better validate user provided tunnel names 109dce20c6ed ip6_tunnel: better validate user provided tunnel names 72363c63b070 ip6_gre: better validate user provided tunnel names The majority of those appear to be on the critical side. -- Steve