On Mon, Apr 16, 2018 at 10:50:15AM +0200, Greg KH wrote: > On Mon, Apr 16, 2018 at 09:43:45AM +0100, Sean Young wrote: > > On Mon, Apr 16, 2018 at 09:52:28AM +0200, Greg KH wrote: > > > What is the git commit id of this patch, and the other patches in this > > > series and the 4.14 patch series that you sent out? > > > > lirc_zilog was dropped in v4.16, so this can't be patched upstream. > > Ah you are right, should we just ditch them here as well as they > obviously do not work? :) > > > > Please read: > > > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > > > for how to do this in a way that I can pick them up. > > > > These patches have been tested with different types of hardware. Is there > > anything else I can do to get these patches included? > > When submitting patches to stable, you need to be explicit as to why > they are needed, and if they are not upstream, why not. > > In this case, for obviously broken code that is not used anymore (as > it is gone in 4.16), why don't we just take the patch that removed the > driver to the stable trees as well? Well in v4.16 the ir-kbd-i2c.c driver can do what the lirc_zilog does in v4.15 (and earlier), so it wasn't ditched as such. It's a case of replaced by mainline. Since I was getting bug reports on it, there must be users of the lirc_zilog driver. That being said, the old lirc_dev and lirc_zilog is pretty awful code. Sean