Re: [PATCH] usb: typec: ucsi: fix link error on randconfig

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 10, 2018 at 10:51:13AM +0300, Heikki Krogerus wrote:
> If building a kernel without FTRACE but with TRACING,
> ucsi.ko fails to link due to missing trace events. Fix this
> by using the correct Kconfig symbol on Makefile.
> 
> Reported-by: Tobias Regnery <tobias.regnery@xxxxxxxxx>
> Fixes: c1b0bc2dabfa ("usb: typec: Add support for UCSI interface")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> ---
>  drivers/usb/typec/ucsi/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/ucsi/Makefile b/drivers/usb/typec/ucsi/Makefile
> index b57891c1fd31..7afbea512207 100644
> --- a/drivers/usb/typec/ucsi/Makefile
> +++ b/drivers/usb/typec/ucsi/Makefile
> @@ -5,6 +5,6 @@ obj-$(CONFIG_TYPEC_UCSI)	+= typec_ucsi.o
>  
>  typec_ucsi-y			:= ucsi.o
>  
> -typec_ucsi-$(CONFIG_FTRACE)	+= trace.o
> +typec_ucsi-$(CONFIG_TRACING)	+= trace.o
>  
>  obj-$(CONFIG_UCSI_ACPI)		+= ucsi_acpi.o

Tobias send his own version for this. His patch has a better
explanation, so let's use that instead.


Thanks,

-- 
heikki



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]