Re: [PATCH 1/3] staging: wilc1000: fix NULL pointer exception in host_int_parse_assoc_resp_info()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please ignore this patch. I will resubmit the patch again.

On Wed, 11 Apr 2018 15:08:40 +0530
Ajay Singh <ajay.kathat@xxxxxxxxxxxxx> wrote:

> Commit fe014d4e6b55 (staging: wilc1000: free memory allocated for
> general info message from firmware) introduced bug by using wrong
> source address in kmemdup(). 'conn_info.req_ies' is used for source
> address in kempdup() instead of 'hif_drv->usr_conn_req.ies'.
> 
> This commit fixes the NULL pointer dereference issue in
> host_int_parse_assoc_resp_info() by using the correct source
> address in kmemdup().
> 
> Fixes: fe014d4e6b55 (staging: wilc1000: free memory allocated for
> general info message from firmware)
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx>
> Tested-by: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx>
> ---
>  drivers/staging/wilc1000/host_interface.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wilc1000/host_interface.c
> b/drivers/staging/wilc1000/host_interface.c index 316d73c..302e3cb
> 100644 --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -1387,7 +1387,7 @@ static inline void
> host_int_parse_assoc_resp_info(struct wilc_vif *vif, }
>  
>  	if (hif_drv->usr_conn_req.ies) {
> -		conn_info.req_ies = kmemdup(conn_info.req_ies,
> +		conn_info.req_ies =
> kmemdup(hif_drv->usr_conn_req.ies, hif_drv->usr_conn_req.ies_len,
>  					    GFP_KERNEL);
>  		if (conn_info.req_ies)



Regards,
Ajay



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]