Re: [PATCH 4.9 3/3] virtio_net: check return value of skb_to_sgvec in one more location

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 09, 2018 at 06:21:50PM -0700, Nathan Chancellor wrote:
> Kernels that do not have f6b10209b90d ("virtio-net: switch to use
> build_skb() for small buffer") will have an extra call to skb_to_sgvec
> that is not handled by e2fcad58fd23 ("virtio_net: check return value of
> skb_to_sgvec always"). Since the former does not appear to be stable
> material, just fix the call up directly.
> 
> Cc: Jason A. Donenfeld <Jason@xxxxxxxxx>
> Cc: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
> Cc: "Michael S. Tsirkin" <mst@xxxxxxxxxx>
> Cc: Jason Wang <jasowang@xxxxxxxxxx>
> Cc: David S. Miller <davem@xxxxxxxxxxxxx>
> Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
> ---
> 
> Greg, if you feel this should be squashed into the previous commit, by
> all means, feel free. I am not entirely sure if the dev_kfree_skb is
> necessary here, I was hoping to get some review.

You did the right thing here by "not squashing" this into the previous
patch, thanks!

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]