On Thu, Apr 5, 2018 at 2:03 PM, Michael S. Tsirkin <mst@xxxxxxxxxx> wrote: > > nr = get_user_pages_fast(addr, nr, gup->flags & 1, pages + i); > - i += nr; > + if (nr > 0) > + i += nr; Can we just make this robust while at it, and just make it if (nr <= 0) break; instead? Then it doesn't care about zero vs negative error, and wouldn't get stuck in an endless loop if it got zero. Linus