On Tue, Apr 03, 2018 at 03:17:16PM +0100, Ben Hutchings wrote: > On Fri, 2018-03-23 at 10:54 +0100, Greg Kroah-Hartman wrote: > > 4.4-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Hans de Goede <hdegoede@xxxxxxxxxx> > > > > > > [ Upstream commit 382bd4de61827dbaaf5fb4fb7b1f4be4a86505e7 ] > > > > When requesting a shared irq with IRQF_TRIGGER_NONE then the irqaction > > flags get filled with the trigger type from the irq_data: > > > > if (!(new->flags & IRQF_TRIGGER_MASK)) > > new->flags |= irqd_get_trigger_type(&desc->irq_data); > > The code above was added to __setup_irq() in 4.8, so I don't think this > fix is needed in 3.18 or 4.4; and I suspect it might cause a regression > there. Already reverted, thanks! greg k-h