Re: [PATCH v4.9.y 09/27] arm64: mm: Map entry trampoline into trampoline and kernel page tables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 03, 2018 at 12:09:05PM +0100, Mark Rutland wrote:
> From: Will Deacon <will.deacon@xxxxxxx>
> 
> commit 51a0048beb44 upstream.
> 
> The exception entry trampoline needs to be mapped at the same virtual
> address in both the trampoline page table (which maps nothing else)
> and also the kernel page table, so that we can swizzle TTBR1_EL1 on
> exceptions from and return to EL0.
> 
> This patch maps the trampoline at a fixed virtual address in the fixmap
> area of the kernel virtual address space, which allows the kernel proper
> to be randomized with respect to the trampoline when KASLR is enabled.
> 
> Reviewed-by: Mark Rutland <mark.rutland@xxxxxxx>
> Tested-by: Laura Abbott <labbott@xxxxxxxxxx>
> Tested-by: Shanker Donthineni <shankerd@xxxxxxxxxxxxxx>
> Signed-off-by: Will Deacon <will.deacon@xxxxxxx>
> Signed-off-by: Alex Shi <alex.shi@xxxxxxxxxx>
> Reviewed-by: Mark Rutland <mark.rutland@xxxxxxx> [v4.9 backport]

It has just been pointed out to me that I messed up the SoB chain here,
and this should be:

Signed-off-by: Mark Rutland <mark.rutland@xxxxxxx> [v4.9 backport]

Otherwise, the patch itself is fine. Sorry for the noise there -- I hope
this can be fixed up when applying?

Thanks,
Mark.



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]