Re: [PATCH 2/3] virt: vbox: Use __get_free_pages instead of kmalloc for DMA32 memory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 29, 2018 at 01:21:15PM +0200, Hans de Goede wrote:
> @@ -87,7 +88,7 @@ void vbg_req_free(void *req, size_t len)
>  	if (!req)
>  		return;
>  
> -	kfree(req);
> +	free_pages((unsigned long)req, get_order(PAGE_ALIGN(len)));
>  }

Really?  This feels wrong to me, why is this driver so special that it
has to use free_pages and the like?

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]