On Mon, 14 Oct 2013 18:12:34 +0800 Weijie Yang <weijie.yang@xxxxxxxxxxx> wrote: > The refcount routine was not fit the kernel get/put semantic exactly, > There were too many judgement statements on refcount and it could be minus. > > This patch does the following: > > - move refcount judgement to zswap_entry_put() to hide resource free function. > > - add a new function zswap_entry_find_get(), so that callers can use easily > in the following pattern: > > zswap_entry_find_get > .../* do something */ > zswap_entry_put > > - to eliminate compile error, move some functions declaration > > This patch is based on Minchan Kim <minchan@xxxxxxxxxx> 's idea and suggestion. > > ... > > @@ -815,7 +809,7 @@ static void zswap_frontswap_invalidate_area(unsigned type) > */ > while ((node = rb_first(&tree->rbroot))) { > entry = rb_entry(node, struct zswap_entry, rbnode); > - rb_erase(&entry->rbnode, &tree->rbroot); > + zswap_rb_erase(&tree->rbroot, entry); > zbud_free(tree->pool, entry->handle); > zswap_entry_cache_free(entry); > atomic_dec(&zswap_stored_pages); > -- zswap_frontswap_invalidate_area() has changed significantly in curent mainline, so this will need redoing please. -- To unsubscribe from this list: send the line "unsubscribe stable" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html