On 14 March 2018 at 19:33, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Wed, Mar 14, 2018 at 8:13 AM, Joel Stanley <joel@xxxxxxxxx> wrote: >> When we removed the inclusion of skeleton.dtsi from the device trees, we >> broke booting for systems with bootloaders that aren't device tre aware. >> This can be seen, for example, when appending the device tree blob to >> the kernel image. >> >> The reason booting broke was that the kernel lacked the device_type >> label in the memory node. Add in a default memory node wth the >> device_type. It can contain the memory address as the location is fixed >> for each SoC generation, but the size needs to be added by the >> bootloader or the board specific dts. >> >> Fixes: 73102d6fdc32 ("ARM: dts: aspeed: Remove skeleton.dtsi") >> Cc: <stable@xxxxxxxxxxxxxxx> >> Reported-by: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> >> Signed-off-by: Joel Stanley <joel@xxxxxxxxx> >> --- >> Arnd, can you please merge this as a fix for 4.16? > > Sure, applied to fixes branch now. Thanks! Has this been sent to Linus?