[PATCH] MIPS: Make the default for PHYSICAL_START always 64-bit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Make the default for PHYSICAL_START always 64-bit, ensuring that a 
correct sign-extended value is used if a 32-bit image is loaded by a 
64-bit system, and matching how the load address is set in platform 
Makefile fragments (arch/mips/*/Platform) in the absence of the 
PHYSICAL_START configuration option.

Of course PHYSICAL_START itself is a misnomer as the load address is 
virtual rather than physical (or otherwise sign-extension would not 
apply).

Signed-off-by: Maciej W. Rozycki <macro@xxxxxxxx>
Fixes: 7aa1c8f47e7e ("MIPS: kdump: Add support")
Cc: stable@xxxxxxxxxxxxxxx # 3.8+
---
Hi James,

 As discussed in the context of commit 27c524d17430 ("MIPS: Use the entry 
point from the ELF file header").  This may require verifying by someone 
who actually uses this feature.  I have cc-ed Maxim, the original author, 
in case he has anything to add.

 I'm not sure if we want to do anything about the physical vs virtual load
address confusion.

 Please consider.

  Maciej
---
 arch/mips/Kconfig |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

linux-mips-physical-start.diff
Index: linux-jhogan-test/arch/mips/Kconfig
===================================================================
--- linux-jhogan-test.orig/arch/mips/Kconfig	2018-03-21 17:22:12.000000000 +0000
+++ linux-jhogan-test/arch/mips/Kconfig	2018-03-23 09:19:25.049100000 +0000
@@ -2849,8 +2849,7 @@ config CRASH_DUMP
 
 config PHYSICAL_START
 	hex "Physical address where the kernel is loaded"
-	default "0xffffffff84000000" if 64BIT
-	default "0x84000000" if 32BIT
+	default "0xffffffff84000000"
 	depends on CRASH_DUMP
 	help
 	  This gives the CKSEG0 or KSEG0 address where the kernel is loaded.



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]