Hi Marcel,
On 23-03-18 12:23, Marcel Holtmann wrote:
Hi Hans,
Add irq_polarity module option for easier troubleshooting of irq-polarity
issues.
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
Marcel, is there any reason why this (bug-fix) series is not merged
yet? Any review remarks I missed?
I was waiting for net to be merged back into net-next so that I don’t have to deal with conflicts.
Ah ok, no problem. I was just wondering if there was anything
I needed to do.
I would really like to move over to using btuart.c that I posted a few days ago, but that will be obviously more work and maybe it is good to stabilize and simplify this inside hci_bcm.c first.
Yes I already saw your remark about this a few days ago. I do think that
moving to btuart.c eventually is a good idea, but your RFC seemed somewhat
feature incomplete. Mainly lacking the runtime-pm stuff, which is not
only needed for powersaving, but on some machines the shutdown gpio
defaults to "off", so the bluetooth won't work until we at a minimum
have added gpio support to btuart.c.
So for now I would like to get things fixed in hci_bcm.c first, as
you suggest. This will also allow easily getting the IRQ polarity and
missing IDs (at least those IDs which are confirmed to be actually
used) fixed in current stable kernels.
I'm afraid I don't have time to help much with btuart.c my hci_bcm.c
work is a small part of a project I'm working on to better support
Bay and Cherry Trail devices and that project itself is a personal
side-project. But when btuart.c is more feature complete I would be
happy to test it on various devices I own which have an uart attach
broadcom bt device.
Regards,
Hans