Patch "Revert "led: core: Fix brightness setting when setting delay_off=0"" has been added to the 4.9-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a note to let you know that I've just added the patch titled

    Revert "led: core: Fix brightness setting when setting delay_off=0"

to the 4.9-stable tree which can be found at:
    http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
     revert-led-core-fix-brightness-setting-when-setting-delay_off-0.patch
and it can be found in the queue-4.9 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@xxxxxxxxxxxxxxx> know about it.


>From jacek.anaszewski@xxxxxxxxx  Thu Mar 22 11:56:58 2018
From: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>
Date: Mon, 19 Mar 2018 20:23:18 +0100
Subject: Revert "led: core: Fix brightness setting when setting delay_off=0"
To: stable@xxxxxxxxxxxxxxx, gregkh@xxxxxxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx, linux-leds@xxxxxxxxxxxxxxx, pavel@xxxxxx, jacek.anaszewski@xxxxxxxxx
Message-ID: <1521487399-10447-2-git-send-email-jacek.anaszewski@xxxxxxxxx>

From: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>

This reverts commit 86b9fa2190907f4f550d9d6bf490c5f89ca33836 which was
commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c upstream.

The commit being reverted has two flaws:
 - it introduces a regression, fixed in the upstream
   commit 7b6af2c53192f1766892ef40c8f48a413509ed72.
 - it has truncated commit message

Reported-by: Sasha Levin <Alexander.Levin@xxxxxxxxxxxxx>
Reported-by: Matthias Schiffer <mschiffer@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Jacek Anaszewski <jacek.anaszewski@xxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
 drivers/leds/led-core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/leds/led-core.c
+++ b/drivers/leds/led-core.c
@@ -186,7 +186,7 @@ void led_blink_set(struct led_classdev *
 		   unsigned long *delay_on,
 		   unsigned long *delay_off)
 {
-	led_stop_software_blink(led_cdev);
+	del_timer_sync(&led_cdev->blink_timer);
 
 	led_cdev->flags &= ~LED_BLINK_ONESHOT;
 	led_cdev->flags &= ~LED_BLINK_ONESHOT_STOP;


Patches currently in stable-queue which might be from jacek.anaszewski@xxxxxxxxx are

queue-4.9/revert-led-core-fix-brightness-setting-when-setting-delay_off-0.patch
queue-4.9/led-core-clear-led_blink_sw-flag-in-led_blink_set.patch



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]