On 20 March 2018 at 15:42, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Tue, Mar 20, 2018 at 07:52:51AM +0800, Dan Rue wrote: >> On Mon, Mar 19, 2018 at 07:05:21PM +0100, Greg Kroah-Hartman wrote: >> > 4.4-stable review patch. If anyone has any objections, please let me know. >> > >> > ------------------ >> > >> > From: Roger Quadros <rogerq@xxxxxx> >> > >> > >> > [ Upstream commit e2d54fe76997301b49311bde7ba8ef52b47896f9 ] >> > >> > It seems that if L3_INIT clkdomain is kept in HW_AUTO while usb_otg_ss >> > is in use then there are random chances that the usb_otg_ss module >> > will fail to completely idle. i.e. IDLEST = 0x2 instead of 0x3. >> > >> > Preventing L3_INIT from HW_AUTO while usb_otg_ss module is in use >> > fixes this issue. >> > >> > We don't know yet if usb_otg_ss instances 3 and 4 are affected by this >> > issue or not so don't add this flag for those instances. >> > >> > Cc: Tero Kristo <t-kristo@xxxxxx> >> > Signed-off-by: Roger Quadros <rogerq@xxxxxx> >> > Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> >> > Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxxxx> >> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >> >> This fails to build for me on arm32 with default config. >> >> # >> # make -j10 -k -s ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=build-arm multi_v7_defconfig >> # >> # >> # make -j10 -k -s ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=build-arm >> # >> ../arch/arm/mach-omap2/omap_hwmod_7xx_data.c:2243:12: error: 'HWMOD_CLKDM_NOAUTO' undeclared here (not in a function) >> .flags = HWMOD_CLKDM_NOAUTO, >> ^ >> ../scripts/Makefile.build:269: recipe for target 'arch/arm/mach-omap2/omap_hwmod_7xx_data.o' failed >> make[2]: *** [arch/arm/mach-omap2/omap_hwmod_7xx_data.o] Error 1 >> make[2]: Target '__build' not remade because of errors. >> /home/buildslave/workspace/kernel-single-defconfig-builder/defconfig/multi_v7_defconfig/label/builder/Makefile:969: recipe for target 'arch/arm/mach-omap2' failed >> make[1]: *** [arch/arm/mach-omap2] Error 2 >> make[1]: Target '_all' not remade because of errors. >> Makefile:152: recipe for target 'sub-make' failed >> make: *** [sub-make] Error 2 >> make: Target '_all' not remade because of errors. > > I've dropped the patch that caused this problem now, will push out a > -rc2 in a few minutes, thanks. > Didn't see that conversation and sent series to fix this problem. Probably to drop that patch is a better solution. In that case please just ignore my series. Thanks! > greg k-h