On Mon, Mar 19, 2018 at 11:01:00AM -0700, Bart Van Assche wrote:
> Since neither the RCU-protected code in blk_queue_enter() nor
> blk_queue_usage_counter_release() sleeps, regular RCU protection
> is sufficient. Note: scsi_device_quiesce() does not have to be
> modified since it already uses synchronize_rcu().
>
> Reported-by: Tejun Heo <tj@xxxxxxxxxx>
> Fixes: 3a0a529971ec ("block, scsi: Make SCSI quiesce and resume work reliably")
> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx>
> Cc: Hannes Reinecke <hare@xxxxxxxx>
> Cc: Ming Lei <ming.lei@xxxxxxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxx>
> Cc: Johannes Thumshirn <jthumshirn@xxxxxxx>
> Cc: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Oleksandr Natalenko <oleksandr@xxxxxxxxxxxxxx>
> Cc: Martin Steigerwald <martin@xxxxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx # v4.15
Acked-by: Tejun Heo <tj@xxxxxxxxxx>
It'd be great to add a comment to clarify the pairing.
Thanks.
--
tejun