Re: [PATCH 4.14 064/109] dmaengine: bcm2835-dma: Use vchan_terminate_vdesc() instead of desc_free

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 19, 2018 at 09:14:00AM +0200, Peter Ujfalusi wrote:
> 
> 
> On 2018-03-19 05:08, Vinod Koul wrote:
> > On Sun, Mar 18, 2018 at 11:44:51AM +0100, Greg Kroah-Hartman wrote:
> >> On Sun, Mar 18, 2018 at 11:24:17AM +0100, Greg Kroah-Hartman wrote:
> >>>>> This patch is causing a build error on arm and arm64 per i.e.
> >>>>> https://kernelci.org/build/id/5aac017e59b5141cb1b3a4d5/
> >>>>>
> >>>>> Builds are also failing for arm/arm64 on 4.15 and this patch seems to be a
> >>>>> problem there as well, but I have not verified it yet.
> >>>>
> >>>> I think we are missing commit 1c7f072d94e8. Pls cherrypick that as well
> >>>>
> >>>> commit 1c7f072d94e8b697fd9b70cdb268622a18faf522
> >>>> Author: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
> >>>> Date:   Tue Nov 14 16:32:04 2017 +0200
> >>>>
> >>>>     dmaengine: virt-dma: Support for race free transfer termination
> >>>>
> >>>> This adds vchan_terminate_vdesc API..
> >>>
> >>> Thanks, that helped.  I've now added this and send out a -rc2 for this
> >>> kernel.
> >>
> >> Oops, no, that broke the build for all arches :(
> >>
> >> Let me just go drop this patch, and the two dmaengine patches that
> >> relied on this one.  If you think these should be applied to the stable
> >> trees, can you send me a series of working patches?
> > 
> > Okay let me grab your tree and cherry-pick all that is required and send
> > you. Stay tuned...
> 
> I think these are the patches that need to be picked for this to work/compile:
> 
> 2c6929d2ea70 dmaengine: s3c24xx-dma: Use vchan_terminate_vdesc() instead of desc_free
> 3ee7e42f3c9b dmaengine: k3dma: Use vchan_terminate_vdesc() instead of desc_free
> 397c59bce6cb dmaengine: img-mdc-dma: Use vchan_terminate_vdesc() instead of desc_free
> 47d71bc75d07 dmaengine: amba-pl08x: Use vchan_terminate_vdesc() instead of desc_free
> f0dd52c85d61 dmaengine: dma-jz4780: Use vchan_terminate_vdesc() instead of desc_free
> de92436ac40f dmaengine: bcm2835-dma: Use vchan_terminate_vdesc() instead of desc_free
> 174334bcd9f8 dmaengine: edma: Use vchan_terminate_vdesc() instead of desc_free
> b1faf0f564ff dmaengine: omap-dma: Use vchan_terminate_vdesc() instead of desc_free
> 1c7f072d94e8 dmaengine: virt-dma: Support for race free transfer termination
> 6af149d2b142 dmaengine: virt-dma: Add helper to free/reuse a descriptor
> 
> Most probably we missed the 6af149d2b142 and that caused the build failures.

Yeah that looks to be the case, I have pushed out topic/dmaengine_stable
after cherry-picking the old topic branch for these. My build tests passed,
waiting for Fenguuang's bit to bless it and send :)

-- 
~Vinod



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]