Re: [PATCH stable 4.14.y] nvme-rdma: don't suppress send completions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 07, 2018 at 10:41:22AM -0700, Keith Busch wrote:
> On Wed, Mar 07, 2018 at 09:27:21AM -0800, Greg KH wrote:
> > On Mon, Mar 05, 2018 at 09:32:15PM +0200, Sagi Grimberg wrote:
> > > The entire completions suppress mechanism is currently broken because the
> > > HCA might retry a send operation (due to dropped ack) after the nvme
> > > transaction has completed.
> > > 
> > > In order to handle this, we signal all send completions and introduce a
> > > separate done handler for async events as they will be handled differently
> > > (as they don't include in-capsule data by definition).
> > > 
> > > Cc: <stable@xxxxxxxxxxxxxxx> # v4.14+
> > > Signed-off-by: Sagi Grimberg <sagi@xxxxxxxxxxx>
> > > Reviewed-by: Max Gurtovoy <maxg@xxxxxxxxxxxx>
> > > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> > > ---
> > >  drivers/nvme/host/rdma.c | 54 +++++++++++++-----------------------------------
> > >  1 file changed, 14 insertions(+), 40 deletions(-)
> > 
> > What is the git commit id for this patch in Linus's tree?
> 
> Commit b4b591c87f2b0f4ebaf3a68d4f13873b241aa584 upstream

thanks, now queued up.

greg k-h



[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]