On Fri, 2018-03-02 at 09:51 +0100, Greg Kroah-Hartman wrote: > 4.4-stable review patch. If anyone has any objections, please let me > know. > > ------------------ > > From: Matthieu CASTET <matthieu.castet@xxxxxxxxxx> > > > [ Upstream commit 2b83ff96f51d0b039c4561b9f95c824d7bddb85c ] > > With the current code, the following sequence won't work : > echo timer > trigger > > echo 0 > delay_off > * at this point we call > ** led_delay_off_store > ** led_blink_set [...] The commit message got cut truncated here, which resulted in addresses being omitted when it was sent out for review. The upstream commit message refers to a LED_BLINK_SW flag which is not used in 4.4. So this fix probably isn't needed, though I can't tell whether it does any harm. Ben. -- Ben Hutchings Software Developer, Codethink Ltd.