Re: Patch "KVM: x86: move LAPIC initialization after VMCS creation" has been added to the 4.14-stable tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



----- gregkh@xxxxxxxxxxxxxxxxxxx wrote:

> This is a note to let you know that I've just added the patch titled
> 
>     KVM: x86: move LAPIC initialization after VMCS creation
> 
> to the 4.14-stable tree which can be found at:
>    
> https://urldefense.proofpoint.com/v2/url?u=http-3A__www.kernel.org_git_-3Fp-3Dlinux_kernel_git_stable_stable-2Dqueue.git-3Ba-3Dsummary&d=DwIDAg&c=RoP1YumCXCgaWHvlZYR8PZh8Bv7qIrMUB65eapI_JnE&r=Jk6Q8nNzkQ6LJ6g42qARkg6ryIDGQr-yKXPNGZbpTx0&m=Maz6LWKMTB3dNz16rCuylqFxbAmuN_jMYMfsJWQAFFg&s=xUqY2YU9eAMKcYfwjC-gwZHcI3260P5mO4BpR_YGViM&e=
> 
> The filename of the patch is:
>      kvm-x86-move-lapic-initialization-after-vmcs-creation.patch
> and it can be found in the queue-4.14 subdirectory.
> 
> If you, or anyone else, feels it should not be added to the stable
> tree,
> please let <stable@xxxxxxxxxxxxxxx> know about it.
> 
> 
> From 0b2e9904c15963e715d33e5f3f1387f17d19333a Mon Sep 17 00:00:00
> 2001
> From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> Date: Fri, 23 Feb 2018 23:29:32 +0100
> Subject: KVM: x86: move LAPIC initialization after VMCS creation
> 
> From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> 
> commit 0b2e9904c15963e715d33e5f3f1387f17d19333a upstream.
> 
> The initial reset of the local APIC is performed before the VMCS has
> been
> created, but it tries to do a vmwrite:
> 
>  vmwrite error: reg 810 value 4a00 (err 18944)
>  CPU: 54 PID: 38652 Comm: qemu-kvm Tainted: G        W I     
> 4.16.0-0.rc2.git0.1.fc28.x86_64 #1
>  Hardware name: Intel Corporation S2600CW/S2600CW, BIOS
> SE5C610.86B.01.01.0003.090520141303 09/05/2014
>  Call Trace:
>   vmx_set_rvi [kvm_intel]
>   vmx_hwapic_irr_update [kvm_intel]
>   kvm_lapic_reset [kvm]
>   kvm_create_lapic [kvm]
>   kvm_arch_vcpu_init [kvm]
>   kvm_vcpu_init [kvm]
>   vmx_create_vcpu [kvm_intel]
>   kvm_vm_ioctl [kvm]
> 
> Move it later, after the VMCS has been created.
> 
> Fixes: 4191db26b714 ("KVM: x86: Update APICv on APIC reset")
> Cc: stable@xxxxxxxxxxxxxxx
> Cc: Liran Alon <liran.alon@xxxxxxxxxx>
> Signed-off-by: Paolo Bonzini <pbonzini@xxxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

This commit broke a rare configuration.
Don't we want to apply this to stable-tree together with the fix for that?
The fix is at upstream commit b7e31be38558 ("KVM: x86: fix vcpu initialization with userspace lapic")

-Liran




[Index of Archives]     [Linux Kernel]     [Kernel Development Newbies]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]