On Mon, Mar 5, 2018 at 11:42 AM, Mark Brown <broonie@xxxxxxxxxx> wrote: > On Sat, Mar 03, 2018 at 10:29:00PM +0000, Sasha Levin wrote: >> From: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx> >> >> [ Upstream commit 9ba2da5f5d18daaa365ab5426b05e16f1d114786 ] >> >> The driver doesn't have a struct of_device_id table but supported devices >> are registered via Device Trees. This is working on the assumption that a >> I2C device registered via OF will always match a legacy I2C device ID and >> that the MODALIAS reported will always be of the form i2c:<device>. >> >> But this could change in the future so the correct approach is to have an >> OF device ID table if the devices are registered via OF. > > As the commit message itself says this is not fixing anything, it's > defence against future changes. That's correct. These were just preparatory patches for a change in the I2C subsystem to properly report OF module aliases [0]. So these will only be relevant once [0] is merged, but that patch will never be backported to a stable kernel. [0]: https://patchwork.kernel.org/patch/10089425/ Best regards, Javier