On Tue 27 Feb 22:25 PST 2018, Marcel Holtmann wrote: > > btq->cmd_channel = qcom_wcnss_open_channel(wcnss, "APPS_RIVA_BT_CMD", > > btqcomsmd_cmd_callback, btq); > > - if (IS_ERR(btq->cmd_channel)) > > - return PTR_ERR(btq->cmd_channel); > > + if (!btq->cmd_channel) > > + return -ENOENT; > > Any reason not to fix qcom_wcnss_open_channel to use PTR_ERR? > Not that I can come up with, and obviously I did expect it to do so in the past. I'll do that. Thanks, Bjorn