+cgroups@xxxxxxxxxxxxxxx
On 10/10/13, Anjana V Kumar <anjanavk12@xxxxxxxxx> wrote:
> Hi All,
>
> Please find the attached patch making the changes for the case where thread
> is already in the required cgroup.
>
> Can you please let me know if this is the right way to fix this issue, if
> any modifications are required.
>
> Thanks and Regards
> Anjana
>
>
> On Wed, Oct 9, 2013 at 7:35 PM, Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
>
>> On 10/09, Oleg Nesterov wrote:
>> >
>> > On 10/09, Li Zefan wrote:
>> > >
>> > > Anjana, could you revise the patch and send it out with proper
>> changelog
>> > > and Signed-off-by? And please add "Cc: <stable@xxxxxxxxxxxxxxx> #
>> 3.9+"
>> >
>> > Yes, Anjana, please!
>>
>> Please note also that the PF_EXITING check has the same problem, it also
>> needs "goto next".
>>
>> > > > check in the main loop. So Anjana was right (sorry again!), and we
>> > > > should probably do
>> > > >
>> > > > ent.cgrp = task_cgroup_from_root(...);
>> > > > if (ent.cgrp != cgrp) {
>> > > > retval = flex_array_put(...);
>> > > > ...
>> > > > }
>> > > >
>> > > > if (!threadgroup)
>> > > > break;
>> > > >
>> > >
>> > > Or
>> > >
>> > > do {
>> > > ...
>> > > if (ent.cgrp == cgrp)
>> > > goto next;
>> >
>> > Or this, agreed.
>> >
>> > > > Or I am wrong again?
>> > >
>> > > No, you are not! :)
>> >
>> > Thanks ;)
>> >
>> > Oleg.
>>
>>
>
>
> --
> Anjana
>
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html