Subject: + devpts-plug-the-memory-leak-in-kill_sb.patch added to -mm tree
To: ihadzic@xxxxxxxxxxxxxxxxxxxxxx,stable@xxxxxxxxxxxxxxx,sukadev@xxxxxxxxxxxxxxxxxx
From: akpm@xxxxxxxxxxxxxxxxxxxx
Date: Wed, 09 Oct 2013 15:09:00 -0700
The patch titled
Subject: devpts: plug the memory leak in kill_sb
has been added to the -mm tree. Its filename is
devpts-plug-the-memory-leak-in-kill_sb.patch
This patch should soon appear at
http://ozlabs.org/~akpm/mmots/broken-out/devpts-plug-the-memory-leak-in-kill_sb.patch
and later at
http://ozlabs.org/~akpm/mmotm/broken-out/devpts-plug-the-memory-leak-in-kill_sb.patch
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/SubmitChecklist when testing your code ***
The -mm tree is included into linux-next and is updated
there every 3-4 working days
------------------------------------------------------
From: Ilija Hadzic <ihadzic@xxxxxxxxxxxxxxxxxxxxxx>
Subject: devpts: plug the memory leak in kill_sb
When devpts is unmounted, there may be a no-longer-used IDR tree hanging
off the superblock we are about to kill. This needs to be cleaned up
before destroying the SB.
The leak is usually not a big deal because unmounting devpts is typically
done when shutting down the whole machine. However, shutting down an LXC
container instead of a physical machine exposes the problem (the garbage
is detectable with kmemleak).
Signed-off-by: Ilija Hadzic <ihadzic@xxxxxxxxxxxxxxxxxxxxxx>
Cc: Sukadev Bhattiprolu <sukadev@xxxxxxxxxxxxxxxxxx>
Cc: <stable@xxxxxxxxxxxxxxx>
Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
---
fs/devpts/inode.c | 1 +
1 file changed, 1 insertion(+)
diff -puN fs/devpts/inode.c~devpts-plug-the-memory-leak-in-kill_sb fs/devpts/inode.c
--- a/fs/devpts/inode.c~devpts-plug-the-memory-leak-in-kill_sb
+++ a/fs/devpts/inode.c
@@ -498,6 +498,7 @@ static void devpts_kill_sb(struct super_
{
struct pts_fs_info *fsi = DEVPTS_SB(sb);
+ ida_destroy(&fsi->allocated_ptys);
kfree(fsi);
kill_litter_super(sb);
}
_
Patches currently in -mm which might be from ihadzic@xxxxxxxxxxxxxxxxxxxxxx are
devpts-plug-the-memory-leak-in-kill_sb.patch
--
To unsubscribe from this list: send the line "unsubscribe stable" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html